retitle 541390 Incorrect provides and dependencies in init.d script
thanks

I noticed another problem with the init.d script dependencies.  During
shutdown, the umountiscsi.sh script should run before the open-iscsi
script, and the former have a stop dependency on open-iscsi but the
open-iscsi script do not provide open-iscsi.  This patch implement
fixes that issue, by making sure open-iscsi provide open-iscsi.

diff -ru open-iscsi-2.0.870~rc3/debian/open-iscsi.init 
open-iscsi-2.0.870~rc3-pere/debian/open-iscsi.init
--- open-iscsi-2.0.870~rc3/debian/open-iscsi.init       2009-09-05 
10:04:17.000000000 +0200
+++ open-iscsi-2.0.870~rc3-pere/debian/open-iscsi.init  2009-09-05 
10:53:23.000000000 +0200
@@ -1,6 +1,6 @@
 #! /bin/sh
 ### BEGIN INIT INFO
-# Provides:          iscsi
+# Provides:          open-iscsi iscsi
 # Required-Start:    $local_fs
 # Required-Stop:     $remote_fs sendsigs networking
 # Default-Start:     S

An alternative is to change the umountiscsi.sh dependency from
open-iscsi to iscsi, but I believe it is a good idea for a script to
provide its own name for predictability, and thus propose the above
patch instead.

Without this change, the shutdown order will be wrong.  For concurrent
shutdown will run the two scripts in parallel, while with sequencial
shutdown the umountiscsi.sh script will run after open-iscsi.

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to