On Sun, 2009-09-06 at 17:14 +0200, Guillaume Chazarain wrote: > Here is attached your patch ported to the latest git version, and with > some changes I made:
Those seem fine. > - Prompt in bold instead of wasting a line I did this so that iotop behaves and looks more like top. Either way is fine for me in any case. > I have some doubt about this particular hunk in your patch: ... > Why do you need this change? Without it, when you ionice one thread of a process and then sort by the priority, iotop will crash because key is '?', which is only one character long and "return -ord(key[1])" tries to access past the end of the 'key' string. This is also a bug without the ionice patch but I guess no-one ever hit it because they don't use ionice. I guess I should have separated this out into another patch. -- bye, pabs http://wiki.debian.org/PaulWise
signature.asc
Description: This is a digitally signed message part
