+++ Neil Williams [2009-09-07 22:24 +0100]: > On Mon, 7 Sep 2009 16:38:58 +0100 > Wookey <[email protected]> wrote: > > > removes apt-preferences warning, > > defaults arch to build arch if not set > > OK. > > > errors out if not aptsources or sources URLs are given > > I don't think we need to die here, we can make a sensible assumption > and continue.
OK. I think if were to pick something from the build machine's config that would make sense, but I decided my perl wasn't up to that so it was better to point out the problem (especially given that this is exactly where you get to if you copy the man page example). > The manpage change will have to be postponed - the package is in a > string freeze for manpage translation. OK, but it does need fixing in due course as it currently lead you to a broken config :-) > > + > > +unless (keys %sources and defined @aptsources) > > defined is misleading here, needs to be omitted. > > The alternative is to put into a scalar context: > > if (scalar @aptsources == 0) > (this is an explicit expansion of the shorthand you've used but > 'defined' is wrong for an array.) > > (Putting @foo into scalar context returns the number of entries in the > array.) Right - yes that's exactly what I wanted to check but was just flappig about, guessing. > > + # For a native multistrap could get some defaults out > > + # of /etc/apt/ config in this case? > > Better than that, if no apt sources are defined, collate all the > existing apt sources and use them. I don't see a need to do this for > native and not do it on not-native - we can't tell from the apt sources > whether they support the requested architecture anyway. I thought for non-native it was rather less likely that 'same as this machine' would be the desired answer. I.e. it might be better to stop and say 'you really ought to specify something'. Dunno. Either way could work. I'm thinking of multistrap being used as a debootstrap replacement. That means that more options should come from the command-line, so one can easily say 'do me a lenny debootstrap from this source in this dir' or the 'sensible defaulting' might suffice. If it could grok debootstrap syntax that might make it a practical replacement? Wookey -- Principal hats: iEndian - Balloonboard - Toby Churchill - Emdebian http://wookware.org/ -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
