Hi Antonio!
On Wed, 02 Sep 2009, Antonio Radici wrote:
> I'm currently co-maintaining mutt in Debian and we are shipping your
> compressed folder patch by default. We got a report from an user
> [0], he had problem with compressed folders when mbox_type is set as
> Maildir by default; I know that this is a known bug and your website
> is clear about it but the patch is not reporting an error if the
> message is not written, therefore the user could lose the existing
> message ('save' will delete the message by default).
>
> I had a look at your code, the solution seems very simple, in
> mutt_open_append_compressed you're checking the DefaultMagic and
> only if it is M_MBOX or M_MMDF, you do create the temporary
> path. I'm wondering, if this function is called only for compressed
> folders, why do you care so much about the DefaultMagic and you
> don't just create the path straight away?
To say the truth, I only adapt this patch to new version of mutt, but
I didn't write it myself. So I do not know, why the original author
did it this way. And I didn't look into this patch for such a long
time, that I do not remember how it works internally.
> This would fix the problem because if the path is created,
> mx_open_mailbox_append() will call stat and it will be successfull,
> otherwise, if the path is not created, the mutt function wil create
> the default one (in this case a maildir) and it will behave badly
> (i.e.: no message saved).
>
> I've the intention of removing that DefaultMagic check, but I was
> wondering if there was any reason for it, something that I'm
> probably missing.
Just do it. If it works, I'd like to incorporate it in my patch :-)
Tschoeeee
Roland
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
