tags 318649 + patch
thanks
Hello
Thanks for the patch. I'll forward it upstream so it get into the
new upstream version.
Regards,
// Ola
On Sat, Jul 16, 2005 at 09:11:55PM +0100, Rob Andrews wrote:
> Package: imp4
> Version: 4.0.2-2
> Severity: normal
>
> imp4's toolbar renders 1em lower than any other toolbar in the horde3
> suite.
>
> At first I thought it was caused by a PHP warning that leaked into the
> output HTML, but it's actually padding on forms that mozilla renders
> mistakenly.
>
> Here's a patch that fixes the undefined value warning and sets 0 pixel
> padding on the form. The toolbar sits in it's correct position upon
> applying this.
>
> (nb: sorry I didn't patch the source tree, it was easier to edit in
> place so I could see the results in a browser)
>
> diff -urN usr/share/horde3/imp/lib/IMP.php /usr/share/horde3/imp/lib/IMP.php
> --- usr/share/horde3/imp/lib/IMP.php 2005-04-10 20:08:10.000000000 +0100
> +++ /usr/share/horde3/imp/lib/IMP.php 2005-06-30 15:01:11.000000000 +0100
> @@ -582,7 +582,7 @@
>
> /* Add the list of mailboxes to the lists. */
> $showmbox = false;
> - if (is_null($filter[0])) {
> + if (!isset($filter[0])) {
> $showmbox = true;
> array_shift($filter);
> }
> diff -urN usr/share/horde3/imp/templates/menu.inc
> /usr/share/horde3/imp/templates/menu.inc
> --- usr/share/horde3/imp/templates/menu.inc 2005-01-27 00:07:59.000000000
> +0000
> +++ /usr/share/horde3/imp/templates/menu.inc 2005-07-11 12:53:43.000000000
> +0100
> @@ -7,7 +7,7 @@
> ?>
> <div id="menu">
> <?php if ($conf['user']['allow_folders']): ?>
> - <form action="mailbox.php" method="get" name="menu">
> + <form action="mailbox.php" method="get" name="menu" style="padding: 0px;">
> <?php Util::pformInput() ?>
> <input type="hidden" name="no_newmail_popup" value="1" />
> <table class="folderselect" style="float:right;" cellspacing="0">
>
> -- System Information:
> Debian Release: 3.1
> Architecture: i386 (i686)
> Kernel: Linux 2.6.12.1
> Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1)
>
> Versions of packages imp4 depends on:
> ii horde3 3.0.4-4 horde web application framework
> ii php4-imap 4:4.3.10-15 IMAP module for php4
>
> -- no debconf information
>
>
--
--------------------- Ola Lundqvist ---------------------------
/ [EMAIL PROTECTED] Annebergsslingan 37 \
| [EMAIL PROTECTED] 654 65 KARLSTAD |
| +46 (0)54-10 14 30 +46 (0)70-332 1551 |
| http://www.opal.dhs.org UIN/icq: 4912500 |
\ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
---------------------------------------------------------------
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
