Ross Burton 提到: > On Fri, 2009-09-18 at 14:51 +0800, Ying-Chun Liu (PaulLiu) wrote: >> I've made a patch to address this problem. >> Please see the attachment and check if it is correct. >> I've already simply tested it and will upload a new package soon. > > I don't agree with this patch because you're pulling in libnm-glib for a > setup which might involve Connman. If that is present in the distro > when you're using Network Manager (and can set that), if it isn't then > you're probably using connman and you can set that too. > > A fallback mode would using dbus directly for both NM and CM, but not > that we switched to libnm-glib because there is a lot of logic there > (reconnection handling, mainly) which is tiresome to replicate. > > Ross
Hi Ross,
Sorry. I don't get it. Do you mean that some system install both ConnMan and
NetworkManager? That is
not an usual case I think.
My patch is not good because it will make mojito links to libnm-glib so that it
depends on
libnm-glib even we don't need it. But when it detects ConnMan is running, it
will not call any libnm
functions due to the logic of the patch.
I think this is just a temporary solution.
Another solution might be let ConnMan provides NM dbus compatible interface.
Or we can make mojito depends on ConnMan as ConnMan is also in Debian now.
Do you have any idea to solve this bug since ConnMan is in Debian now and we
don't want to avoid
users to use it. And I think there's no default desktop environment in Debian
so we should not
assume that Debian uses NetworkManager at beginning.
Regards,
Paul
--
PaulLiu(劉穎駿)
E-mail address: [email protected]
signature.asc
Description: OpenPGP digital signature
