Package: ripit
Version: 3.6.0-1
Severity: important
on mp3 encoding, ripit tries to determine the genre a wrong way, this
results in endless loop at genre check.
the given patch fixes it: lame --genre-list outputs on stderr, not
stdout.
-- System Information:
Debian Release: 5.0.3
APT prefers stable
APT policy: (500, 'stable')
Architecture: i386 (i686)
Kernel: Linux 2.6.26-2-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages ripit depends on:
ii cdparanoia 3.10.2+debian-5 audio extraction tool for sampling
ii faac 1.26-0.2 an AAC audio encoder
ii flac 1.2.1-1.2 Free Lossless Audio Codec - comman
ii lame 3.98.2-0.4 LAME Ain't an MP3 Encoder
ii libcddb-get-perl 2.23-2.1 read the CDDB entry for an audio C
ii libwww-perl 5.813-1 WWW client/server library for Perl
ii vorbis-tools 1.2.0-5 several Ogg Vorbis tools
ripit recommends no packages.
Versions of packages ripit suggests:
ii eject 2.1.5+deb1-4 ejects CDs and operates CD-Changer
ii id3 0.15-1 An ID3 Tag Editor
ii id3v2 0.1.11-3 A command line id3v2 tag editor
-- no debconf information
--- ripit.old 2009-09-25 04:11:06.000000000 +0200
+++ ripit.new 2009-09-25 04:09:03.000000000 +0200
@@ -3398,7 +3398,7 @@
# If Lame is not used, don't die if ID3v2-tag is not compliant.
if($lameflag == 0) {
- unless(log_system("lame --genre-list | grep -i \" $genre\$\" > /dev/null
")) {
+ unless(log_system("lame --genre-list 2>&1 | grep -i \" $genre\$\" >
/dev/null ")) {
print "Genre $genre is not ID3v2 compliant!\n"
if($verbose >= 1);
print "I continue anyway!\n\n" if($verbose >= 1);
@@ -3417,7 +3417,7 @@
# Check if (similar) genre exists. Enter a new one with interaction,
# or take the default one.
- while(!log_system("lame --genre-list | grep -i \"$genre\" > /dev/null ")) {
+ while(!log_system("lame --genre-list 2>&1 | grep -i \"$genre\" > /dev/null
")) {
print "Genre $genre is not ID3v2 compliant!\n" if($verbose >= 1);
if($interaction == 1) {
print "Use \"lame --genre-list\" to get a list!\n";
@@ -3437,7 +3437,7 @@
return;
}
elsif($genre =~ /^\d+$/) {
- $genre = `lame --genre-list | grep -i \' $genre \'`;
+ $genre = `lame --genre-list 2>&1 | grep -i \' $genre \'`;
chomp $genre;
}
else {
@@ -3449,10 +3449,10 @@
# "pop-like" genres!
# There will be a linebreak, if multiple possibilities found.
my $ogenre = $genre;
- $genre = `lame --genre-list | grep -i \'$genre\'`;
+ $genre = `lame --genre-list 2>&1 | grep -i \'$genre\'`;
chomp $genre;
# Second we want THE original genre, if it precisly exists.
- my $testgenre = `lame --genre-list | grep -i \'\^... $ogenre\$\'`;
+ my $testgenre = `lame --genre-list 2>&1 | grep -i \'\^... $ogenre\$\'`;
chomp $testgenre;
$genre = $testgenre if($testgenre);
# If we still have several genres:
