Package: dancer-services Version: 1.8.0.6.3-6 Severity: important Tags: patch User: [email protected] Usertags: incorrect-dependency User: [email protected] Usertags: piuparts
With dependency based boot sequencing, I discovered what I believe is a bug in the init.d script of this package. The script have a hard dependency on dancer-ircd, yet the package only recommend dancer-ircd. Because of this, the init.d dependency should be a soft dependency. Further, the script uses files in /usr/ and should depend on $remote_fs not $local_fs, and I believe such dependency should be hard. I discovered these things from piuparts, which failed to install the package. See <URLhttp://piuparts.debian.org/sid/fail/dancer-services_1.8.0.6.3-6.log>. Here are the relevant parts: insserv: Service dancer-ircd has to be enabled to start service dancer-services insserv: exiting now! I'm setting severity important and not serous, as dancer-ircd is a recommended package to dancer-services and thus will be installed on most systems. This patch should solve it. diff -ur ../dancer-services-1.8.0.6.3/debian/init.d ../dancer-services-1.8.0.6.3-pere/debian/init.d --- ../dancer-services-1.8.0.6.3/debian/init.d 2009-09-27 08:33:27.000000000 +0200 +++ ../dancer-services-1.8.0.6.3-pere/debian/init.d 2009-09-27 09:17:06.000000000 +0200 @@ -2,10 +2,10 @@ ### BEGIN INIT INFO # Provides: dancer-services -# Required-Start: $syslog dancer-ircd -# Required-Stop: $syslog dancer-ircd -# Should-Start: $local_fs $network $named -# Should-Stop: $local_fs $network $named +# Required-Start: $remote_fs $syslog +# Required-Stop: $remote_fs $syslog +# Should-Start: $network $named dancer-ircd +# Should-Stop: $network $named dancer-ircd # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: Dancer-Services daemon init.d script Happy hacking, -- Petter Reinholdtsen -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
