Hi Petter,

thanks for your bug-report. I created a new version 0.9.2-5 of monkey
with an updated init-script according to your suggestions.
Can you please take a look at it?

You can find it here:
www.adminfromhell.de/debian/

If everything's fine from your side, I'll push the new package to
mentors.debian.net and hope to find a sponsor who can upload it for me
as well.

Thanks and Regards,
Thorsten Schmale

On 27/09/09 13:57 +0200, Petter Reinholdtsen wrote:
> 
> Package:  monkey
> Version:  0.9.2-1
> Severity: important
> Tags:     patch
> User:     [email protected]
> Usertags: incorrect-dependency
> User:     [email protected]
> Usertags: piuparts
> 
> With dependency based boot sequencing, I discovered what I believe is
> a bug in the init.d scripts of this package.  The monkey script have a
> hard dependency on networking, but the package do not depend on
> netbase.  It is better to depend on the virtual facility $network.
> Also, the script uses files in /usr/ and should depend on $remote_fs.
> Finally, the script used to start after syslog, and should probably
> continue to do so.
> 
> I discovered these things from piuparts, which failed to install the
> package.  See
> <URL: http://piuparts.debian.org/sid/fail/monkey_0.9.2-3.log >.
> Here are the relevant parts:
> 
>   insserv: Service networking has to be enabled to start service monkey
>   insserv: exiting now!
> 
> I'm setting severity to important, as the needed netbase package is
> installed on most systems already.
> 
> This patch should solve it.
> 
> diff -ur ../monkey-0.9.2/debian/monkey.init 
> ../monkey-0.9.2-pere/debian/monkey.init
> --- ../monkey-0.9.2/debian/monkey.init  2009-09-27 13:52:15.000000000 +0200
> +++ ../monkey-0.9.2-pere/debian/monkey.init     2009-09-27 13:53:22.000000000 
> +0200
> @@ -1,8 +1,8 @@
>  #!/bin/sh
>  ### BEGIN INIT INFO
>  # Provides:          monkey
> -# Required-Start:    networking
> -# Required-Stop:     networking
> +# Required-Start:    $network $remote_fs $syslog
> +# Required-Stop:     $network $remote_fs $syslog
>  # Default-Start:     2 3 4 5
>  # Default-Stop:      0 1 6
>  # Short-Description: Start the monkey http server.
> 
> Happy hacking,
> -- 
> Petter Reinholdtsen
> 
> 

-- 
I WILL NOT FAKE MY WAY THROUGH LIFE
I WILL NOT FAKE MY WAY THROUGH LIFE
I WILL NOT FAKE MY WAY THROUGH LIFE
I WILL NOT FAKE MY WAY THROUGH LIFE

        Bart Simpson on chalkboard in episode 7F03



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to