Package: xfce4-power-manager Version: 0.8.4-1 Severity: minor Tags: patch -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
The power manager doesn't allow to set the critical level for the battery lower than 5%; this is fine for most laptops, but on netbooks you can still have more than 20 minutes of battery life, and it's a pity to have to choose between doing without automatic hibernation and wasting 20 minutes of work. Since the user is able to set the level he prefers, imposing an arbitrary minimum higher than 1% doesn't really make sense to me. The attached patch sets the minimum to 1%. Cheers, Luca - -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (995, 'unstable'), (991, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores) Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages xfce4-power-manager depends on: ii hal 0.5.13-3 Hardware Abstraction Layer ii libc6 2.9-26 GNU C Library: Shared libraries ii libdbus-1-3 1.2.16-2 simple interprocess messaging syst ii libdbus-glib-1-2 0.82-2 simple interprocess messaging syst ii libglib2.0-0 2.22.1-1 The GLib library of C routines ii libgtk2.0-0 2.18.0-1 The GTK+ graphical user interface ii libnotify1 [libnotify1-gtk2.1 0.4.5-1 sends desktop notifications to a n ii libpango1.0-0 1.26.0-1 Layout and rendering of internatio ii libx11-6 2:1.2.2-1 X11 client-side library ii libxext6 2:1.0.4-1 X11 miscellaneous extension librar ii libxfce4util4 4.6.1-1 Utility functions library for Xfce ii libxfcegui4-4 4.6.1-1+b1 Basic GUI C functions for Xfce4 ii libxfconf-0-2 4.6.1-1 Client library for Xfce4 configure ii xfce4-power-manager-data 0.8.4-1 power manager for Xfce desktop, ar xfce4-power-manager recommends no packages. Versions of packages xfce4-power-manager suggests: ii xfce4-power-manager-plugins 0.8.4-1 power manager plugins for Xfce pan - -- no debconf information -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkrEvfgACgkQ+AQB36CPPlqshACfZnyQDXhgrxBH7154ObFIsHIu /8gAnjdEG/RSeWGNxMVc3QuhDwxxpoGw =PY7v -----END PGP SIGNATURE-----
diff -rNu xfce4-power-manager-0.8.4/data/interfaces/xfpm-settings.ui xfce4-power-manager-0.8.4.new/data/interfaces/xfpm-settings.ui --- xfce4-power-manager-0.8.4/data/interfaces/xfpm-settings.ui 2009-10-01 15:51:49.250367104 +0200 +++ xfce4-power-manager-0.8.4.new/data/interfaces/xfpm-settings.ui 2009-08-28 22:05:52.000000000 +0200 @@ -54,7 +54,7 @@ </object> <object class="GtkAdjustment" id="adjustment9"> <property name="value">10</property> - <property name="lower">5</property> + <property name="lower">1</property> <property name="upper">20</property> <property name="step_increment">1</property> </object> diff -rNu xfce4-power-manager-0.8.4/data/interfaces/xfpm-settings_ui.h xfce4-power-manager-0.8.4.new/data/interfaces/xfpm-settings_ui.h --- xfce4-power-manager-0.8.4/data/interfaces/xfpm-settings_ui.h 2009-10-01 15:54:32.986288702 +0200 +++ xfce4-power-manager-0.8.4.new/data/interfaces/xfpm-settings_ui.h 2009-09-29 11:19:11.000000000 +0200 @@ -35,7 +35,7 @@ "me=\"value\">10</property><property name=\"lower\">9</property><propert" "y name=\"upper\">120</property><property name=\"step_increment\">1</pro" "perty></object><object class=\"GtkAdjustment\" id=\"adjustment9\"><prop" - "erty name=\"value\">10</property><property name=\"lower\">5</property><" + "erty name=\"value\">10</property><property name=\"lower\">1</property><" "property name=\"upper\">20</property><property name=\"step_increment\">" "1</property></object><object class=\"GtkListStore\" id=\"model1\"><colu" "mns><column type=\"gchararray\"/></columns><data><row><col id=\"0\" tra" diff -rNu xfce4-power-manager-0.8.4/settings/xfpm-settings.c xfce4-power-manager-0.8.4.new/settings/xfpm-settings.c --- xfce4-power-manager-0.8.4/settings/xfpm-settings.c 2009-10-01 15:51:07.766357682 +0200 +++ xfce4-power-manager-0.8.4.new/settings/xfpm-settings.c 2009-08-31 11:58:16.000000000 +0200 @@ -1349,7 +1349,7 @@ val = xfconf_channel_get_uint (channel, PROPERTIES_PREFIX CRITICAL_POWER_LEVEL, 10); - if ( val > 20 || val < 5) + if ( val > 20 || val < 1) { g_critical ("Value %d if out of range for property %s\n", val, CRITICAL_POWER_LEVEL); gtk_spin_button_set_value (GTK_SPIN_BUTTON(critical_level), 10); diff -rNu xfce4-power-manager-0.8.4/src/xfpm-xfconf.c xfce4-power-manager-0.8.4.new/src/xfpm-xfconf.c --- xfce4-power-manager-0.8.4/src/xfpm-xfconf.c 2009-10-01 15:48:48.650312202 +0200 +++ xfce4-power-manager-0.8.4.new/src/xfpm-xfconf.c 2009-09-28 17:01:29.000000000 +0200 @@ -237,7 +237,7 @@ PROP_CRITICAL_LEVEL, g_param_spec_uint (CRITICAL_POWER_LEVEL, NULL, NULL, - 5, + 1, 20, 10, G_PARAM_READWRITE));