Package: abcde
Version: 2.4.0-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu lucid ubuntu-patch
Hello dear maintainer,
Please find the patch attached by michael helmling to fix tagged speex syntax
error
cf: https://bugs.edge.launchpad.net/ubuntu/+source/abcde/+bug/350359
We thought you might be interested in doing the same.
-- System Information:
Debian Release: lenny/sid
APT prefers hardy-updates
APT policy: (500, 'hardy-updates'), (500, 'hardy-security'), (500,
'hardy-proposed'), (500, 'hardy')
Architecture: i386 (i686)
Kernel: Linux 2.6.24-24-generic (SMP w/2 CPU cores)
Locale: LANG=en_IN, LC_CTYPE=en_IN (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- abcde-2.4.0.orig/abcde
+++ abcde-2.4.0/abcde
@@ -1123,9 +1123,10 @@
esac
COMMENT="--comment \"$COMMENT\""
fi
- # Quick hack to avoid tagging Ogg/Speex, since
there is no other way to tag than inline tagging
- if [ ! "$DOTAG" = "y" ]; then
- $RUN_COMMAND nice $EFFECTIVE_NICE
$SPEEXENCODER $SPEEXENCODEROPTS --author "$TRACKARTIST" --title "$TRACKNAME"
"$COMMENT" "$IN" "$OUT"
+ # Tag the file at encode time, as it can't be
done after encoding.
+ if [ "$DOTAG" = "y" ]; then
+ $RUN_COMMAND nice $EFFECTIVE_NICE
$SPEEXENCODER $SPEEXENCODEROPTS --author "$TRACKARTIST" --title "$TRACKNAME"
--comment "$COMMENT" "$IN" "$OUT"
+
else
$RUN_COMMAND nice $EFFECTIVE_NICE
$SPEEXENCODER $SPEEXENCODEROPTS "$IN" "$OUT"
fi
@@ -1140,8 +1141,8 @@
$RUN_COMMAND nice $EFFECTIVE_NICE $MPPENCODER
$MPPENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME"
--track "$1" --genre "$CDGENRE" --year "$CDYEAR" --comment "$COMMENT" "$IN"
"$OUT"
;;
m4a)
- # Quick hack to avoid tagging Ogg/Speex, since
there is no other way to tag than inline tagging
- if [ ! "$DOTAG" = "y" ]; then
+ # Tag the file at encode time, as it can't be
done after encoding.
+ if [ "$DOTAG" = "y" ]; then
$RUN_COMMAND nice $EFFECTIVE_NICE
$AACENCODER $AACENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title
"$TRACKNAME" --track "$1" --genre "$CDGENRE" --year "$CDYEAR" --comment
"$COMMENT" -o "$OUT" "$IN"
else
