On Sun, Jul 17, 2005 at 02:38:00PM +0200, Helge Kreutzmann <[EMAIL PROTECTED]> 
wrote:
> As you can see, DEB_BUILD_OPTIONS is completely ignored[1]. Also the
> binary is never build with "-g", (which is the entire reason I wanted
> to rebuild arson, btw). Also "-Wall" is not used.
> 
> First, why do you set CFLAGS in debian/rules? You have a C++-programm
> (correct me if I am wrong)
> so IMHO it should be CXXFLAGS instead. 
> 
> It would be great if you could actually support these flags. But if
> you do not intend to do so, then remove the first lines in
> debian/rules, because the give the reader the impression that you
> actually do support them.
> 
> Please also read section 10.1 (especially the notes for porters!) of
> debian-policy and adapt. It is only a "should" directive to use "-g"
> (and the other points mentioned there), but it helps. 

I've modified that snippet to set CXXFLAGS instead of CFLAGS since there
seems to be nothing that actually uses CFLAGS. I'm also attempting to
override INSTALL_STRIP_PROGRAM for the "nostrip" option, because it's
explicitly defined with -s and used in a few Makefiles.

Let me know if you have any other thoughts on this. I'm dist-upgrading
my box right now so that I can test the build.

-- 
Mike Markley <[EMAIL PROTECTED]>

Everyone is entitled to an informed opinion.
- Harlan Ellison


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to