[Debian BTS gets this because it's tracking the problem, Hanna Wallach
because she is the DD for didiwiki and since I couldn't find an address
for the upstream mailing list Matthew Allum gets a copy as well.]

Martin Samuelsson @ 2005-04-19 (Tuesday), 20:41 (+0200)
> ...
> 
> I could file another bug that didiwiki does not have it's port number
> configurable. Hanna, should I?
> 
> ...

I haven't filed the bug report, but I did take a look at the source code
today. Making it possible to have port number configurable with didiwiki
was trivial. Patch attached.

With the patch "didiwiki --port 8080" works.

Documentation needs to be updated.

Maybe my patch is too simple? It's unexpected behaviour that it takes
the next available when giving a occupied port as it's argument.

When it comes to #305379 in the Debian BTS, I'm not sure if I consider
this work around in another package to solve it. But feel free to
convince me.
--
/Martin
diff -ur didiwiki-0.5/src/didi.c didiwiki-0.5-portpatched/src/didi.c
--- didiwiki-0.5/src/didi.c     2005-07-26 15:36:12.347002053 +0200
+++ didiwiki-0.5-portpatched/src/didi.c 2005-07-26 15:38:24.305804297 +0200
@@ -23,6 +23,7 @@
       static struct option long_options[] = 
        {
          {"debug", no_argument,       0, 'd'},
+         {"port",  required_argument, 0, 'p'},
          {"home",  required_argument, 0, 'h'},
          {0, 0, 0, 0}
        };
@@ -45,6 +46,10 @@
          debug = 1;
          break;
          
+       case 'p':
+         port = atoi(optarg);
+         break;
+         
        case 'h':
          didiwiki_home = optarg;
          break;

Reply via email to