clone 319950 -1
retitle -1 check vbr option before otf
severity -1 minor
found -1 2.99.9-1
found 319950 3.1.1-2
retitle 319950 fix FLAC OTF support, get rid of VBR
tags 319950 pending
tags -1 pending
thanks
* Robert Millan <[EMAIL PROTECTED]> [2005-07-25 23:53]:
> This patch includes fixes for Flac support. Basicaly:
> - Use only a command for best performance, and mark it as such by naming it
> "cmd" instead of "vbr-cmd".
I'm not quite happy with this but I suppose this is okay for now.
Unless Michael objects.
BTW, I don't agree that --best should be the default. We just
probably just leave whatever flac has as default and people can
overwrite it if they want. The same goes for -V.
> - Remove the "otf" command which includes invalid flags (probably was added
> for an old version of flac).
You cannot just remove this. I've updated it.
> - Fix jack_checkopts.py to check for vbr before otf. This way if a backend
> defines otf but not vbr it doesn't exit with error but just fallback to
> the logical non-vbr otf option (this isn't needed currently with flac,
> but it might in the future).
OK, thanks.
diff -urN jack-3.1.1~/jack_helpers.py jack-3.1.1/jack_helpers.py
--- jack-3.1.1~/jack_helpers.py 2005-07-26 23:01:54.741757512 +0100
+++ jack-3.1.1/jack_helpers.py 2005-07-26 23:04:11.752928648 +0100
@@ -207,8 +207,8 @@
'flac': {
'type': "encoder",
'target': "flac",
- 'vbr-cmd': "flac -o %o %i",
- 'vbr-otf-cmd': "flac -fr -fb -fc 2 -fp 16 -fs 44100 -o %o",
+ 'cmd': "flac -o %o %i",
+ 'otf-cmd': "flac --channels 2 --bps 16 --sample-rate 44100
--force-raw-format --endian=big --sign=signed -o %o -",
'status_blocksize': 160,
'status_start': "%",
'percent_fkt': r"""
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
