* Martin Michlmayr <[EMAIL PROTECTED]> [2005-07-26 21:50]:
> MP3 has (at least) two different type of tags, version 1 and version
> 2.  Version 2 supports UTF8 and when you look at your file you should
> see that it has been tagged properly.  jack can also add version 1
> tags and this is what broke in your case.  I'll make it more robust.
> Also, I think we should turn version 1 tags off by default.
> 
> Anyway, you can use the patch below or wait a for days for a new
> package:

Arne, please use this patch instead.  It will also print a warning
when we're only adding v1 tags but they fail.


diff -urN jack-3.1.1~/jack_tag.py jack-3.1.1/jack_tag.py
--- jack-3.1.1~/jack_tag.py     2005-07-27 13:53:36.293534312 +0100
+++ jack-3.1.1/jack_tag.py      2005-07-27 13:54:18.856063824 +0100
@@ -138,7 +138,12 @@
                             tag.setGenre("(%d)" % (cf['_id3_genre']))
                         if cf['_id3_year'] != -1:
                             tag.setDate(cf['_id3_year'])
-                        tag.update()
+                        try:
+                            tag.update()
+                        except UnicodeEncodeError:
+                            if not cf['_write_id3v2']:
+                                print
+                                print "Track %02d contains data not supported 
by id3v1; please use --write-id3v2" % i[NUM]
                         mp3file.close()
                 elif jack_helpers.helpers[cf['_encoder']]['target'] == "ogg":
                     vf = ogg.vorbis.VorbisFile(mp3name)

-- 
Martin Michlmayr
http://www.cyrius.com/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to