Hi James and Teodor James, Thanks for the report. However I will fix the problem instead of switching to bash. That is to add quotes around the export line that caused the problem. Suggestion for next time you provide a patch is that you use the following syntax:
diff -u bin/vzmigrate.old bin/vzmigrate You got it the opposite direction. However it did not do that much as I was able to read the patch and reproduced the problem. When it comes to the echo versus printf I have tested both the original printf solution, your suggestion and the echo solution. As no options are needed to echo there are no compatibility issues in using echo. That is the reason why I'd vote for that one. However I will file a bug against upstream about this and let them decide the solution. In the meantime I will patch it to use echo. Otherwise it is very hard to determine the error both with bash and dash as it is currently not printed. Best regards, // Ola On Sun, Dec 27, 2009 at 07:35:53PM +0200, Teodor MICU wrote: > On Sun, Dec 27, 2009 at 4:31 PM, James Stanley <[email protected]> > wrote: > > Package: vzctl > > Version: 3.0.23-8 > > > > 2.) It should use "echo -ne" instead of "printf" as it passes text as > > separate arguments and printf only prints the first > > Please don't! The recommendation is to go in the oppossite direction > (use "printf" instead of "echo -ne"). For this specific case this is > the correct call: > printf "$*\n" > > For the general case, all arguments to "printf" must be enclosed in "". > > Thanks > > > -- --------------------- Ola Lundqvist --------------------------- / [email protected] Annebergsslingan 37 \ | [email protected] 654 65 KARLSTAD | | http://inguza.com/ +46 (0)70-332 1551 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --------------------------------------------------------------- -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
