On Fri, 8 Jan 2010 00:32:55 +1100, Craig Small <[email protected]> wrote:
> Hello James,
> I had a look at this patch you sent me for adding python support to
> dh-make. As you probably know debhelper has changed a lot, with now
> minimal rules files. This means part of the patch is probably
> redundant, or would need changing to use overrides.
>
> To me it seems your patch makes dh_make detect there is a python
> package, due to finding setup.py and it then changes certain variables
> based upon that.
>
> Some questions
> * Why is XS_PYTHON_VERSION being added to the homepage?
It's fugly, but I think it adds a newline as the first char of that
variable if it is used. This prevents it from adding an extra newline
if it's not a python package.
> * I would suggest a better way for the dependencies would be to have a
> flag ${python:Depends} and then usnig substvars.
This would require changing the python helper tools I think. I wouldn't
be against it, but it would take more work. There's also the fact that
it sort of implies that it is all the python dependencies, when we can't
reliably detect needed modules and the like.
> Do you know of a package within Debian that uses the new debelper 7
> templates well and you would consider a "good" package? ie one to model
> on that is also reasonably simple.
I can't think of one off the top of my head, but anything of Joey's is
probably a good start.
Thanks,
James
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
