found 536792 tcpflow/0.21.ds1-6
quit

I decided to drop this patch, it has bugs which I had somehow missed
in my initial testing:
- non-Ethernet data link types don't support filtering on 'vlan', so
  tcpflow doesn't work at all on them (#558209)
- the patch breaks filtering when the user provides an expression
  because adding 'vlan' in the filter changes the decoding offsets
  in libpcap.

It would be possible to fix the first problem by checking the link
type, and the second can be fixed by changing the expression from
e.g. '(ip or vlan) and (port 80)' to '(ip and port 80) or (vlan and
port 80)', but that's somewhat more involved.

In the end, I'm not comfortable carrying this patch in the package,
so I dropped it in 0.21.ds1-6. If someones provides a better, tested
patch I'll be happy to reconsider.

-- 
Romain Francoise <[email protected]>
http://people.debian.org/~rfrancoise/



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to