Package:  pdns-recursor
Version:  3.1.7.1-3
Severity: seriuos
Tags:     patch
User:     [email protected]
Usertags: incorrect-dependency

This is a followup on #547033, where the init.d boot dependencies were
discussed.

I recently checked out the boot ordering in Debian Edu based on
Squeeze, and came across unexpected ordering of init.d/pdns*.  The
pdns-recursor script is started before the rsyslog script, causing any
syslog messages sent by pdns-recursing during boot to be lost.  The
solution is to add $syslog as a dependency.

Also, I notice that the pdns-recursor script used to start before
pdns, but there is no relationship between these scripts recorded in
their dependency header.  This can be solved two ways.  Either state
in the pdns-recursor script that it should start before pdns, or state
in the pdns script that it should start after pdns-recursor.  As this
is a bug report for pdns-recursor, my proposed patch to the former. :)

The following patch should solve both issues, making sure
pdns-recursor start after the syslog is operational and before pdns.
With the new dependencies in place, the script will be moved to a more
sensible boot order location.

I set severity to seriuos, because I believe pdns-recursor will fail
to work as it should if it happen to start after pdns (which might
happen when concurrent booting is enabled).  If that is not the case,
missing syslog messages during boot is probably just a bug with
severity important.

--- pdns-recursor-3.1.7.2/debian/init.d/pdns-recursor   2010-01-25 
19:24:56.000000000 +0100
+++ pdns-recursor-3.1.7.2-pere/debian/init.d/pdns-recursor      2010-01-25 
19:26:17.000000000 +0100
@@ -1,8 +1,10 @@
 #!/bin/sh
 ### BEGIN INIT INFO
 # Provides:          pdns-recursor
-# Required-Start:    $network $remote_fs
-# Required-Stop:     $network $remote_fs
+# Required-Start:    $network $remote_fs $syslog
+# Required-Stop:     $network $remote_fs $syslog
+# X-Start-Before:    pdns
+# X-Stop-After:      pdns
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: Start the recursor at boot time.

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to