clone 560325 -1
reassign -1 wireshark
thanks

Dear Wireshark maintainers,

As you know,  bug #560325 affects some Wireshark users.  In fact, when a
MIB cannot be loaded because, for example, not all dependencies are met,
this MIB  is still present  in memory but  is incoherent. This  leads to
some segfault when trying to use it.

This bug seems difficult to fix in libsmi. Therefore, it would be better
to  fix the  problem in  wireshark by  checking the  conformance  of the
module before using it. I attach the simple patch to this mail.

To track this  problem, I clone the original bug  report (since it needs
to be fixed in libsmi too).

Thanks.

diff --git a/epan/oids.c b/epan/oids.c
index dcbaef8..704a055 100644
--- a/epan/oids.c
+++ b/epan/oids.c
@@ -583,6 +583,8 @@ void register_mibs(void) {
 		 smiModule = smiGetNextModule(smiModule)) {
 
 		D(3,("\tModule: %s", smiModule->name));
+		if (smiModule->conformance <= 1)
+			continue;
 
 		for (smiNode = smiGetFirstNode(smiModule, SMI_NODEKIND_ANY);
 			 smiNode;
-- 
BOFH excuse #98:
The vendor put the bug there.

Reply via email to