tags 486403 - patch
tags 486403 + wontfix
thanks

Hi George,

George Danchev wrote:

> --- help.c.orig 2008-06-15 23:42:39.000000000 +0300
> +++ help.c      2008-06-15 23:44:06.000000000 +0300
> @@ -504,7 +504,7 @@
> 
>  int cmd_version(int argc, const char **argv, const char *prefix)
>  {
> -       printf("git version %s\n", git_version_string);
> +       printf("git version %s (repo version %d)\n", git_version_string, 
> GIT_REPO_VERSION);
>         return 0;
>  }

Thanks for the patch.  Unfortunately, I do not understand the use for
it.

You see, git’s repository format _has_ changed in incompatible ways a
few times already without any corrusponding bump in the repository
format version.  Examples: the addition of packed refs, and the
addition of alternative packed object formats.  Maybe that is
unfortunate, but it has not caused any major breakage I know of.  Part
of the problem is perhaps that different features are added at the
same time and it is not immediately obvious which one deserves the
higher repository version number.

So the GIT_REPO_VERSION feature ends up being either a failed
experiment or an important futureproofing measure.  Either way, we
won’t know what it means it gets incremented. ;-)

> It will benefit the recently added to the 
> dpkg-source "3.0 (git)" source format.

I think any successful git-based source package format will be based
on pack files rather than checked-out repositories.  That is, I
suspect if anything will work as 4.0 (git), it would be git bundle
based, partially because bundles are meant to be usable with the
endpoints having vastly different git versions.

> So if my git program dies with:
>
> "fatal: Expected git repo version <= V, found V+1"
>
> because repositoryformatversion is bigger than GIT_REPO_VERSION, I
> would like to be able to query its internal GIT_REPO_VERSION in
> order to determine which .git/* my git is able to process.

Isn’t that V in the error message?

Jonathan



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to