On Sat, Feb 27, 2010 at 07:57:49PM +0100, Sebastian Dröge wrote:
> On Sat, 2010-02-27 at 19:53 +0100, Sebastian Dröge wrote:
> > On Sat, 2010-02-27 at 19:42 +0100, Julian Andres Klode wrote:
> > > On Sat, Feb 27, 2010 at 07:35:37PM +0100, Julian Andres Klode wrote:
> > > > Package: gnome-codec-install
> > > > Tags: patch
> > > > User: [email protected]
> > > > Usertags: python-apt-0-8-api
> > > > 
> > > > As part of the python-apt API transition mass bug filing[1],
> > > > I would like to ask you to update your package for the new
> > > > API using the attached patch.
> > > > 
> > > > The first python-apt upload after the Squeeze release will
> > > > drop the old API and will get a 'Breaks' for all packages
> > > > which have not been adjusted yet. All not-fixed bugs will 
> > > > become release critical then.
> > > > 
> > > > [1] http://lists.debian.org/debian-devel/2010/02/msg00424.html
> > > > 
> > > > -- 
> > > > Julian Andres Klode  - Debian Developer, Ubuntu Member
> > > > 
> > > > See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
> > > 
> > > Patch updated, the last one had a few problems.
> > 
> > Thanks for the patch, I'll upload a new version with that patch soon.
> > But which version of python-apt is at least needed for this to work? :)
> 
> Also it still complains about deprecated API:
> 
> /usr/lib/python2.5/site-packages/apt/cache.py:119: DeprecationWarning:
> Deprecated, please use 'subop' instead
>   self._cache = apt_pkg.Cache(progress)
> 

Minimum version from API level is 0.7.93 in your case, although it
may be better to depend on 0.7.93.1, as this includes some more
bugfixes.

I have attached a patch to fix this apt_pkg.Cache warning; seems
I missed that part.


-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
From 90904f94db3884ed2bc91fc83017c3b15329ade8 Mon Sep 17 00:00:00 2001
From: Julian Andres Klode <[email protected]>
Date: Sat, 27 Feb 2010 20:23:16 +0100
Subject: [PATCH 2/2] GnomeCodecInstall/PackageWorker.py: Fix GtkOpProgress to subclass the correct class.

---
 GnomeCodecInstall/PackageWorker.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/GnomeCodecInstall/PackageWorker.py b/GnomeCodecInstall/PackageWorker.py
index da2b6b1..279aae7 100644
--- a/GnomeCodecInstall/PackageWorker.py
+++ b/GnomeCodecInstall/PackageWorker.py
@@ -11,7 +11,7 @@ import os
 import tempfile
 from gettext import gettext as _
 
-class GtkOpProgress(apt.progress.OpProgress):
+class GtkOpProgress(apt.progress.base.OpProgress):
   " a simple helper that keeps the GUI alive "
 
   def update(self, percent):
-- 
1.7.0

Attachment: signature.asc
Description: Digital signature

Reply via email to