On Fri, 2010-03-05 at 04:02 -0600, Jonathan Nieder wrote: > Hi Ben, > > Ben Hutchings wrote: > > > RFC 5322 specifies use of CR LF as the line ending in mail messages. > > git format-patch uses LF which is conventional for Unix but not valid > > when transmitting messages over IMAP. git imap-send needs to convert > > LF to CR LF. > > Sounds reasonable, but could you describe a symptom? The main > priority for git imap-send is that it must successfully get patches to > the other end, not that it follow RFC 5322. (Of course one affects > the other; I am just saying an example of what this breaks would be > helpful. If this is only a theoretical problem for now, it still > would be worth fixing, just a lower priority.)
Cyrus imapd rejects these messages. (And this didn't happen with earlier versions of git; it is a recent regression.) > Also, (because I am lazy) do you know of a very simple IMAP server one > could use to reproduce this? It would be nice to add a test for this > to the git test suite, but without such a shim, that might be hard. Sorry, no. Ben. -- Ben Hutchings Q. Which is the greater problem in the world today, ignorance or apathy? A. I don't know and I couldn't care less.
signature.asc
Description: This is a digitally signed message part
