On Sat, Aug 06, 2005 at 12:40:45AM -0700, Steve Langasek wrote: > On Sat, Aug 06, 2005 at 08:54:26AM +0200, Sven Luther wrote: > > Altough after a suggestion from Steve, this should rather be : > > > --- /usr/share/kernel-package/rules 2005-07-28 07:22:16.000000000 +0200 > > +++ rules 2005-08-01 19:04:56.000000000 +0200 > > @@ -2560,7 +2560,7 @@ > > debian/post-install; \ > > fi > > ifeq ($(strip $(NEED_IMAGE_POST_PROCESSING)),YES) > > - if test grep $(IMAGE_POST_PROCESS_TARGET) > > $(IMAGE_POST_PROCESS_DIR)/Makefile 2>&1 >/dev/null; then \ > > + if test grep -q $(IMAGE_POST_PROCESS_TARGET) > > $(IMAGE_POST_PROCESS_DIR)/Makefile; then \ > > $(MAKE) INSTALL_MKVMLINUZ=$(INSTALL_MKVMLINUZ_PATH) \ > > ARCH=$(KERNEL_ARCH) -C $(IMAGE_POST_PROCESS_DIR) > > $(IMAGE_POST_PROCESS_TARGET); \ > > fi > > No, it shouldn't. I said to use > > if grep -q $(IMAGE_POST_PROCESS_TARGET) $(IMAGE_POST_PROCESS_DIR)/Makefile; > then \ > > But in both cases, the problem is this extra "test" that had no business > being there in the first place. There's no reason to be calling test when > you have a perfectly good program you can already check the exit value of.
Ah, sorry, my bad, i tested it without the test, and it worked, bad copy paste here again. Friendly, Sven Luther -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
