Hello Mathieu! (I stripped off zack from CC as he's not interested in this descussion)
On Wed, Apr 07, 2010 at 11:02:32AM -0400, Mathieu Trudel-Lapierre wrote: > Andreas or Stefano, would you be able to review my package for > emerillon, since it is complete? (see > http://mentors.debian.net/debian/pool/main/e/emerillon/ ) > We're getting quite off topic for this bugreport, but here's my quick review anyway. (In the future, please post RFS to debian-ment...@lists.debian.org and feel free to CC me). General nitpicks: please remove empty/useless files/directories under debian/ (e.g. patches/series) You should fix the libethos-ui-dev bug rather then working around it by adding libethos-ui-1.0-0 to you build-dependecies. More importantly: I'm not particularily found of you building an "orig" tarball from upstream git. The upstream git repo and the upstream orig tarball doesn't match. Your tarball will miss any files added by upstream during make dist. Your tarball checksum will not match the upstream checksum making it hard to verify it's not been tampered with. You have many build-dependencies which is only needed because you're using a git snapshot rather then the actual release tarball. Since you're using CDBS anyway, I suggest you look at gnome-pkg-tools helper script for downloading the actual orig tarballs from ftp.gnome.org instead. This way you could also have a functional debian/watch file. Another suggestion would be to ask for this package to be maintained in pkg-gnome by the gnome packaging team. Since emerillon is very "gnomey", it would likely be accepted and you'd get the benefit of team maintenance when you're busy while it would lower the barrier for you to help out with other gnome(-related) packages which I'm sure the gnome packaging team would appreciate. :) > Also, I'm not entirely familiar with the NMU process, could someone > clarify what I am supposed to do at this point, either by email, or we > could get in contact on IRC... To summarize what zack said, if you do nothing the bug will be fixed in 2 days... after that you should make sure to incorporate zacks changes in your next ethos upload. -- Andreas Henriksson
signature.asc
Description: Digital signature
