Hi Guido, > I do like this approach but I'm a bit worried about git-import-orig > becoming non interactive. Maybe it'd help to add a generic --interactive > variable. In case of interactive = False we'd not prompt for anything.
Hmm, but what do you do then? Fail with an error instead of prompting? Or just go ahead with the guessed value (which might very well be false?). I'm not so sure that explicitely telling git-import-orig to run non-interactively is useful, instead you should just give it enough information so prompting is not needed. With the current code, to keep import non-interactive, you need to make sure there is a debian/changelog file (for the package name) and pass --upstream-version. Perhaps a --package-name would be useful as well, so you can actually run non-interactively on the first import as well, without breaking stuff because of the missing symlink? Perhaps using the special package name and version "guess" to force accepting the guessed values, for when you know they'll be right? e.g.,: git-import-orig --package-name guess --upstream-version guess package-1.0.tar.gz As for the general idea of this patch: I've been using it for a while now, and considering most of my upstream packages use a packagename-version-source.tar.gz tarball (and considering that some of them need version some mangling), the prompting really works well for me :-) Gr. Matthijs
signature.asc
Description: Digital signature
