On Wed, 14 Apr 2010, Colin Watson wrote:
> The fsync/rename deferral in 1.15.6.1 doesn't actually seem to work
> properly; strace doesn't show fsync at all for tarobjects. No wonder it
> performed well! Admittedly I'm testing with my attempt to backport this
> change to Ubuntu, but nevertheless I think I found a real bug:
>
> if (ti->Type == NormalFile0 || ti->Type == NormalFile0) {
>
> The second of those should be NormalFile1. Since modern tar files
> generally use NormalFile1 rather than NormalFile0, the rename-deferral
> path is never taken.
Good catch, I applied your patch.
Cheers,
--
Raphaël Hertzog
Like what I do? Sponsor me: http://ouaza.com/wp/2010/01/05/5-years-of-freexian/
My Debian goals: http://ouaza.com/wp/2010/01/09/debian-related-goals-for-2010/
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
