Package: liboop4
Version: 1.0-6
Some years ago I contributed a feature for reading lines and records
to liboop: oop-read.h and read.c. Since it took a while for that
feature to make it into distributed versions, for a long time I've
been using my own copy of the source file. It seems that I fixed a
couple of bugs in my copy which are still in the Debian package. I
can't find any record of me having told anyone about them and now I
find that 1.0-6 still has the bugs.
So anyway, here's the patch with my apologies. Could you apply it to
the Debian package, and also forward it upstream for me ?
There are two fixes:
* Initialise "rd->discard" properly
* Avoid rd->neednotcheck becoming negative
Thanks,
Ian.
--- /home/ian/things/trains/hostside/__oop-read-copy.c 2005-06-26
18:26:34.000000000 +0100
+++ read.c 2003-07-18 15:46:22.000000000 +0100
@@ -114,7 +114,6 @@
rd->allocbuf= 0;
rd->used= 0;
rd->alloc= buf ? bufsz : 0;
- rd->discard= 0;
rd->neednotcheck= 0;
rd->displacedchar= -1;
rd->style= *OOP_RD_STYLE_IMMED;
@@ -236,11 +235,7 @@
if (rd->discard) {
rd->used -= rd->discard;
- if (rd->neednotcheck > rd->discard) {
- rd->neednotcheck -= rd->discard;
- } else {
- rd->neednotcheck= 0;
- }
+ rd->neednotcheck -= rd->discard;
memmove(buf, buf + rd->discard, rd->used);
rd->discard= 0;
}
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
