Package: libdbm-deep-perl
Version: 1.0022-1
Severity: important
User: debian-p...@lists.debian.org
Usertags: perl-5.12-transition
Tags: patch

This package fails to build with perl_5.12.0-1 from experimental:

  t/01_basic.t .................... ok
  Use of uninitialized value $_ in lc at 
/build/niko-libdbm-deep-perl_1.0022-1-i386-4RBZoH/libdbm-deep-perl-
  1.0022/blib/lib/DBM/Deep/Storage/DBI.pm line 60.
  # Tests were run but no plan was declared and done_testing() was not seen.
  t/02_hash.t ..................... 
  Dubious, test returned 255 (wstat 65280, 0xff00)
  All 50 subtests passed 
  [...]
  
Apparently Test::More gives up because of the warning. The attached
rather hackish patch fixes the immediate problem.
-- 
Niko Tyni   nt...@debian.org
>From 982bff2c101a90c56d5314138b868eb8b56a6050 Mon Sep 17 00:00:00 2001
From: Niko Tyni <nt...@debian.org>
Date: Tue, 4 May 2010 09:22:24 +0300
Subject: [PATCH] Fix a test failure with Perl 5.12.0

Perl 5.12.0 introduces new uninitialized warnings for the lc* and uc*
functions, breaking the test suite.
---
 lib/DBM/Deep/Storage/DBI.pm |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/DBM/Deep/Storage/DBI.pm b/lib/DBM/Deep/Storage/DBI.pm
index 8b6c403..3ce8813 100644
--- a/lib/DBM/Deep/Storage/DBI.pm
+++ b/lib/DBM/Deep/Storage/DBI.pm
@@ -57,7 +57,9 @@ sub open {
     ) or die $DBI::error;
 
     # Should we use the same method as done in new() if passed a $dbh?
+    { no warnings 'uninitialized';
     (undef, $self->{driver}) = map lc, DBI->parse_dsn( $self->{dbi}{dsn} );
+    }
 
     return 1;
 }
-- 
1.7.1

Reply via email to