Subject: emms calls tramp when it tries to play an url Package: emms Version: 3.0-6 Severity: normal Tags: sid patch
*** Please type your report below this line *** emms calls tramp whenever it tries to play an url, causing the url not to be played. This is due to the emms-player-mplayer-subtitle-checker function in the file emms-player-mplayer.el. Since commit, ed66137edc089844ccc8162d09a259e5acf7c32d (2008-04-01 13:22:00), this function has been removed because mplayer has an option(`sub-fuzziness') for loading movie subtitles automatically. ed66137edc089844ccc8162d09a259e5acf7c32d.diff is a diff file to upgrade the emms-player-mplayer.el file in the current sid package. Therefore, this bug was previously fixed in commit 40d7162d906ab9776d8b592e446bf1abc0763010 (2007-11-04 14:38:00), the latest commit of the emms-player-mplayer.el file with this functionnality is the 0d86b1844c9173c24889896c0531c75973b75e57 (2008-03-15 09:28:00). 0d86b1844c9173c24889896c0531c75973b75e57.diff is a diff file to upgrade with this latest revision the emms-player-mplayer.el file in the current sid package. Regards, Jonathan Marchand -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686-bigmem (SMP w/2 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages emms depends on: ii dpkg 1.15.7.1 Debian package management system ii emacs23 23.1+1-8 The GNU Emacs editor (with GTK+ us ii emacsen-common 1.4.19 Common facilities for all emacsen ii install-info 4.13a.dfsg.1-5 Manage installed documentation in ii libc6 2.10.2-6 Embedded GNU C Library: Shared lib ii libtagc0 1.6.2-1 TagLib Audio Meta-Data Library (C Versions of packages emms recommends: ii mpg321 0.2.11-2+b1 Simple and lighweight command line ii vorbis-tools 1.4.0-1 several Ogg Vorbis tools Versions of packages emms suggests: ii mp3info 0.8.5a-1 An MP3 technical info viewer and I -- debconf-show failed
3c3
< ;; Copyright (C) 2005, 2006, 2007 Free Software Foundation, Inc.
---
> ;; Copyright (C) 2005, 2006, 2007, 2008 Free Software Foundation, Inc.
27c27,29
< ;; seeking.
---
> ;; seeking. For loading subtitles automatically, try adding
> ;; "sub-fuzziness=1" to your `~/.mplayer/config', see mplayer manual for
> ;; more.
34,39d35
< (defcustom emms-player-mplayer-subtitle-extensions
< '("sub" "srt" "gb.srt" "big5.srt")
< "Possible movie subtitle file extensions."
< :type 'symbol
< :group 'emms)
<
41,43c37,41
< (regexp-opt '(".ogg" ".mp3" ".wav" ".mpg" ".mpeg" ".wmv" ".wma"
< ".mov" ".avi" ".divx" ".ogm" ".asf" ".mkv" "http://"; "mms://"
< ".rm" ".rmvb" ".mp4" ".flac" ".vob" ".m4a"))
---
> (mapconcat 'regexp-quote
> '(".ogg" ".mp3" ".wav" ".mpg" ".mpeg" ".wmv" ".wma"
> ".mov" ".avi" ".divx" ".ogm" ".asf" ".mkv" "http://"; "mms://"
> ".rm" ".rmvb" ".mp4" ".flac" ".vob" ".m4a" ".ape")
> "\\|")
83,113d80
<
< (defun emms-player-mplayer-subtitle-checker ()
< (let* ((track (emms-playlist-current-selected-track))
< (name (emms-track-name track))
< (ext (file-name-extension name))
< (choices
< (emms-remove-if-not 'file-exists-p
< (mapcar (lambda (el)
< (emms-replace-regexp-in-string
< (concat ext "$") el name))
< emms-player-mplayer-subtitle-extensions)))
< (subtitle (mapconcat (lambda (el) el) choices ",")))
< (unless (string= subtitle "")
< (setq emms-player-mplayer-parameters
< (append emms-player-mplayer-parameters
< (list "-sub" subtitle))))))
<
< (defun emms-player-mplayer-start-with-subtitle-checker (track)
< "Start the player process by checking possible subtitles
< additionally."
< (let ((emms-player-mplayer-parameters emms-player-mplayer-parameters))
< (emms-player-mplayer-subtitle-checker)
< (emms-player-simple-start (emms-track-name track)
< emms-player-mplayer
< emms-player-mplayer-command-name
< emms-player-mplayer-parameters)))
<
< ;; I have to redefine `emms-player-mplayer-start', since i can't figure
< ;; out an easy way to achieve this based on current design. (xwl)
< (defalias 'emms-player-mplayer-start
< 'emms-player-mplayer-start-with-subtitle-checker)
35c35
< '("sub" "srt" "gb.srt" "big5.srt")
---
> '("sub" "srt" "gb.srt" "big5.srt" "eng.srt" "chs.srt" "cht.srt")
41,43c41,45
< (regexp-opt '(".ogg" ".mp3" ".wav" ".mpg" ".mpeg" ".wmv" ".wma"
< ".mov" ".avi" ".divx" ".ogm" ".asf" ".mkv" "http://"; "mms://"
< ".rm" ".rmvb" ".mp4" ".flac" ".vob" ".m4a"))
---
> (mapconcat 'regexp-quote
> '(".ogg" ".mp3" ".wav" ".mpg" ".mpeg" ".wmv" ".wma"
> ".mov" ".avi" ".divx" ".ogm" ".asf" ".mkv" "http://"; "mms://"
> ".rm" ".rmvb" ".mp4" ".flac" ".vob" ".m4a" ".ape")
> "\\|")
89c91,94
< (emms-remove-if-not 'file-exists-p
---
> (emms-remove-if-not (lambda (i)
> (or (and (eq (emms-track-type track) 'file)
> (file-exists-p i))
> (eq (emms-track-type track) 'url)))
94c99
< (subtitle (mapconcat (lambda (el) el) choices ",")))
---
> (subtitle (mapconcat 'identity choices ",")))
signature.asc
Description: Digital signature
