Bug#322070: gksu: sigsegv at startup with -u root option

[Gustavo Noronha Silva]

Em Qua, 2005-08-10 às 02:02 +0200, kenoby escreveu:
> (gdb) run -u root /usr/sbin/synaptic
> Starting program: /usr/bin/gksu -u root /usr/sbin/synaptic
> [Thread debugging using libthread_db enabled]
> [New Thread -1217714496 (LWP 5659)]
> 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread -1217714496 (LWP 5659)]
> 0x0804ca9e in main (argc=4, argv=0xbfa6e5d4) at gksu.c:1097
> 1097          if (!strcmp (tmp, "default"))
> 
> (gdb) bt
> #0  0x0804ca9e in main (argc=4, argv=0xbfa6e5d4) at gksu.c:1097

That helps! =)

I believe I understand the problem now. Would you mind trying the
attached patch? Simply droping it into debian/patches and rebuilding the
package should do.

Thanks,

-- 
[EMAIL PROTECTED]: Gustavo Noronha <http://people.debian.org/~kov>
Debian:  <http://www.debian.org>  *  <http://www.debian-br.org>


Index: ChangeLog
===================================================================
--- ChangeLog	(revisão 402)
+++ ChangeLog	(cópia de trabalho)
@@ -1,3 +1,10 @@
+2005-08-09  Gustavo Noronha Silva  <[EMAIL PROTECTED]>
+
+	* gksu/gksu.c, gksu/gksu.schemas.in:
+	- correct the schema to have save-keyring be string; check
+	  if gconf_client_get_string returns something valid in that
+	  case, anyway
+
 2005-08-07  Gustavo Noronha Silva  <[EMAIL PROTECTED]>
 
 	* Release 1.3.2
Index: gksu/gksu.schemas.in
===================================================================
--- gksu/gksu.schemas.in	(revisão 402)
+++ gksu/gksu.schemas.in	(cópia de trabalho)
@@ -117,8 +117,8 @@
       <key>/schemas/apps/gksu/save-keyring</key>
       <applyto>/apps/gksu/save-keyring</applyto>
       <owner>gksu</owner>
-      <type>bool</type>
-      <default>true</default>
+      <type>string</type>
+      <default>session</default>
       <locale name="C">
 	<short>Keyring to which passwords will be saved</short>
 	<long>
Index: gksu/gksu.c
===================================================================
--- gksu/gksu.c	(revisão 402)
+++ gksu/gksu.c	(cópia de trabalho)
@@ -1078,7 +1078,7 @@
     {
       GtkWidget *vbox;
       GtkWidget *check_button;
-      gchar *tmp;
+      gchar *tmp = NULL;
 
       vbox = gtk_vbox_new (2, TRUE);
       gtk_box_pack_start (GTK_BOX(GKSUUI_DIALOG(dialog)->entry_vbox), vbox, TRUE, TRUE, 0);
@@ -1094,7 +1094,7 @@
       check_button = gtk_check_button_new_with_label (_("Save password in the keyring"));
       g_signal_connect (G_OBJECT(check_button), "toggled", G_CALLBACK(cb_toggled_cb), "save-keyring");
       tmp = gconf_client_get_string (gconf_client, BASE_PATH"save-keyring", NULL);
-      if (!strcmp (tmp, "default"))
+      if (tmp && (!strcmp (tmp, "default")))
 	gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON(check_button), TRUE);
       g_free (tmp);
       gtk_box_pack_start (GTK_BOX(vbox), check_button, TRUE, TRUE, 0);

signature.asc
Description: This is a digitally signed message part