Package: albatross
Version: 1.36-5.3
Severity: important
Tags: patch
User: debian-pyt...@lists.debian.org
Usertags: python2.6
User: ubuntu-de...@lists.ubuntu.com
Usertags: ubuntu-patch maverick

Hi, in addition to the now fixed Bug #556146, your package fails to
build from source when Python 2.6 is the default version. It fails in
the tests:

| PYTHONPATH=.. python all.py
| /tmp/b/albatross-1.36/albatross/context.py:20: DeprecationWarning: the sha 
module is deprecated; use the hashlib module instead
|   import hmac, sha
| 
..................................................................................................................................cannot
 unpickle - imp_hook() takes at most 4 arguments (5 given)
| E.....
| ======================================================================
| ERROR: module_decode (misc.pagemodule.PageModuleCase)
| ----------------------------------------------------------------------
| Traceback (most recent call last):
|   File "/tmp/b/albatross-1.36/test/misc/pagemodule.py", line 103, in 
module_decode
|     ctx.decode_session(session)
|   File "/tmp/b/albatross-1.36/albatross/context.py", line 659, in 
decode_session
|     raise ApplicationError("can't unpickle session")
| ApplicationError: can't unpickle session
| 
| ----------------------------------------------------------------------
| Ran 136 tests in 0.239s
| 
| FAILED (errors=1)

Ubuntu has been carrying a patch for this for a while, attached. The latest
version from upstream (1.40) also claims to fix this.

SR

-- 
Stefano Rivera
  http://tumbleweed.org.za/
  H: +27 21 465 6908 C: +27 72 419 8559  UCT: x3127
diff -pruN 1.36-5.2/albatross/context.py 1.36-5.2ubuntu2/albatross/context.py
--- 1.36-5.2/albatross/context.py	2007-03-19 05:17:09.000000000 +0000
+++ 1.36-5.2ubuntu2/albatross/context.py	2010-02-06 13:31:34.000000000 +0000
@@ -644,11 +644,11 @@ class SessionBase:
         self.clear_locals()
 
     def decode_session(self, text):
-        def imp_hook(name, globals=None, locals=None, fromlist=None):
+        def imp_hook(name, globals=None, locals=None, fromlist=None, level=-1):
             if self.app.is_page_module(name):
                 return self.app.load_page_module(self, name)
             else:
-                return real_imp(name, globals, locals, fromlist)
+                return real_imp(name, globals, locals, fromlist, level)
 
         real_imp, __builtin__.__import__ = __builtin__.__import__, imp_hook
         try:

Attachment: signature.asc
Description: Digital signature

Reply via email to