Gorazd K a écrit : > Package: lm-sensors > Version: 1:3.1.2-2 > Severity: normal > > If there's an error in the /etc/fancontrol config file, fancontrol > init.d script makes it look like everything is OK. Here's a sample > session where INTERVAL has been commented out to illustrate the problem: > > # cat /etc/fancontrol > # Configuration file generated by pwmconfig, changes will be lost > #INTERVAL=30 > DEVPATH=hwmon0=devices/platform/coretemp.0 > hwmon2=devices/platform/w83627ehf.656 > DEVNAME=hwmon0=coretemp hwmon2=w83627dhg > FCTEMPS=hwmon2/device/pwm2=hwmon0/device/temp1_input > hwmon2/device/pwm1=hwmon2/device/temp1_input > FCFANS=hwmon2/device/pwm2=hwmon2/device/fan2_input > hwmon2/device/pwm1=hwmon2/device/fan3_input > MINTEMP=hwmon2/device/pwm2=40 hwmon2/device/pwm1=40 > MAXTEMP=hwmon2/device/pwm2=45 hwmon2/device/pwm1=43 > MINSTART=hwmon2/device/pwm2=150 hwmon2/device/pwm1=55 > MINSTOP=hwmon2/device/pwm2=185 hwmon2/device/pwm1=155 > MINPWM=hwmon2/device/pwm2=185 hwmon2/device/pwm1=155 > MAXPWM=hwmon2/device/pwm2=255 hwmon2/device/pwm1=255 > # /usr/sbin/fancontrol > Loading configuration from /etc/fancontrol ... > Some mandatory settings missing, please check your config file! > # invoke-rc.d fancontrol start > Starting fan speed regulator: fancontrol. > # ps auxw | grep fanc > root 29708 0.0 0.0 1740 540 pts/4 S+ 16:57 0:00 grep fanc > # > > Notice how /usr/sbin/fancontrol script detectes the problem, but init.d > script does not. The reason is that it uses start-stop-daemon with the > '--background' switch, which says: > > WARNING: start-stop-daemon cannot check the exit status if the > process fails to execute for any reason.
Agreed, but that's the only way to start pwmconfig, as it doesn't fork by itself. > Another thing is this check in the init.d script: > > grep INTERVAL $CONF | cut -d= -f2 > > This ignores comments as in the above example, but at the same time, > even if this would work, other failures will not be detected (say if > MINSTOP is lower than MINPWM). I'll add those checks to the initscript. -- Aurelien Jarno GPG: 1024D/F1BCDB73 [email protected] http://www.aurel32.net -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
