On Wed, Jun 16, 2010 at 01:39:32PM +0900, Paul Mundt wrote:
> On Tue, Jun 15, 2010 at 10:18:51PM +0200, Aurelien Jarno wrote:
> > Package: u-boot
> > Version: 2010.06~rc1-6
> > Severity: normal
> > User: [email protected]
> > Usertags: sh4
> > 
> > u-boot currently fails to build on SH4, as cross-compilation is 
> > detected, and sh4-linux-gcc is then called. This can simply be fixed
> > by the following patch:
> > 
> > --- u-boot-2010.06~rc1.orig/Makefile
> > +++ u-boot-2010.06~rc1/Makefile
> > @@ -40,7 +40,8 @@ HOSTARCH := $(shell uname -m | \
> >         -e s/sa110/arm/ \
> >         -e s/ppc64/powerpc/ \
> >         -e s/ppc/powerpc/ \
> > -       -e s/macppc/powerpc/)
> > +       -e s/macppc/powerpc/ \
> > +       -e s/sh.*/sh/)
> >  
> 
> This will break sh64. I suggest just using the same matching as we do in
> the kernel instead:
> 
> SUBARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \
>                                   -e s/arm.*/arm/ -e s/sa110/arm/ \
>                                   -e s/s390x/s390/ -e s/parisc64/parisc/ \
>                                   -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
>                                   -e s/sh[234].*/sh/ )
> 

I didn't thought about sh64 when writing the patch, your solution is
indeed better.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to