Hi,
I've been reviewing the few remaining packages in s-p-u in preparation
for the upcoming point release and had a couple of comments / queries on
your "mon" upload.
- echo -n "Starting $DESC: "
- start-stop-daemon --start --quiet --pidfile $PIDFILE --chuid $USER
--group $GROUP --exec $DAEMON -- $DAEMON_OPTS
- echo "$NAME."
+ if [ -f $PIDFILE ] ; then
+ echo "$NAME daemon is already running."
+ else
+ echo -n "Starting $DESC: "
+ start-stop-daemon --start --oknodo --pidfile $PIDFILE --chuid
$USER --group $GROUP --exec $DAEMON -- $DAEMON_OPTS
+ echo "$NAME."
+ fi
This looks like it should work, but would simply running the
"start-stop-daemon --start --oknodo" call in all cases not work, given
that it uses the pid file?
The "restart" section, on the other hand, is still not policy compliant:
restart)
- echo -n "Restarting $DESC: "
- start-stop-daemon --stop --quiet --pidfile $PIDFILE
- sleep 1
- start-stop-daemon --start --quiet --pidfile $PIDFILE --chuid $USER
--group $GROUP --exec $DAEMON -- $DAEMON_OPTS
- echo "$NAME."
+ if [ -f $PIDFILE ] ; then
+ echo -n "Restarting $DESC: "
+ start-stop-daemon --stop --quiet --pidfile $PIDFILE
+ sleep 1
+ start-stop-daemon --start --quiet --pidfile $PIDFILE --chuid
$USER --group $GROUP --exec $DAEMON -- $DAEMON_OPTS
+ echo "$NAME."
+ else
+ echo "$NAME daemon is not running."
+ echo "To start $NAME run: /etc/init.d/mon start"
+ fi
Policy 9.3.2 says:
`restart'
stop and restart the service if it's already running, otherwise
start the service
which your updated script does not fulfil (specifically the "otherwise
start the service" section).
For future reference, it would be appreciated if you could send a mail
containing a debdiff and a brief explanation of the changes you'd like
to make to debian-rele...@lists.debian.org and wait for an ok, rather
than uploading directly to s-p-u; this allows us to review the patch and
makes it easier to incorporate any required changes.
Regards,
Adam
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
