On Sun, Jun 20, 2010 at 05:52:04PM +0200, Stefano Rivera wrote:
> Package: maxima-emacs
> User: [email protected]
> Usertags: origin-ubuntu maverick ubuntu-patch
> Version: 5.21.1-1
> Severity: minor
> Tags: patch
>
> PS: I can't comment on the content of this patch as I didn't author it
> and am not an emacs user.
I came to this bug report because of the verbosity when byte-compiling so,
besides suggesting another change, I will comment a bit on some of these
changes,
>> In Ubuntu, we've applied the attached patch to achieve the following:
>
> - debian/maxima-emacs.emacsen-install:
> + Install symlinks for source files rather than copying them. This
> makes find-function work.
> + Install symlink for *.lisp so that we don't need to add
> /usr/share/emacs/site-lisp/maxima to load-path.
Please consider above changes. That is the way most emacsen add-on packages
behave.
> - debian/maxima-emacs.emacsen-startup:
> + Remove use of /usr/share/emacs/site-lisp/maxima, since this
> causes load-path shadows and is not needed anymore.
This seems also useful. Path for $flavour byte-compiled files is already
included and, if symlinks to .el files are included, they are available
from the $flavour dir.
> - Comment out backward-delete-char-untabify in maxima.el.
Seems that nothing appears about this in given reference at
> These changes originated (a while ago) in this report:
> https://bugs.launchpad.net/ubuntu/+source/maxima/+bug/124415
but I could find info at
https://bugs.launchpad.net/ubuntu/+source/maxima/+bug/5273
Seems that what was done is to rebind delete key to delete backwards.
Removing the lines as in Ubuntu patch is reported to restore the standard
behaviour. I'd suggest a more descriptive changelog entry, something like
- Do not rebind delete key to `backward-delete-char-untabify' (delete
backwards)
And now an additional suggestion. byte-compilation of maxima emacsen files
is way too verbose because startup files are loaded for no good reason.
Please consider attached patch. Note that it only uses '-no-start-file', the
XEmacs form. Current FSF Emacs also supports that, so that is no problem.
Suggested changelog entry:
- Do not load site-files when byte-compiling.
Cheers,
--
Agustin
--- maxima-emacs.emacsen-install.orig 2010-06-29 15:01:59.000000000 +0200
+++ maxima-emacs.emacsen-install 2010-06-29 16:07:38.000000000 +0200
@@ -12,12 +12,9 @@
echo install/${PACKAGE}: Handling install for emacsen flavor ${FLAVOR}
-#FLAVORTEST=`echo $FLAVOR | cut -c-6`
-#if [ ${FLAVORTEST} = xemacs ] ; then
-# SITEFLAG="-no-site-file"
-#else
-# SITEFLAG="--no-site-file"
-#fi
+# Do not load startup files when byte-compiling.
+SITEFLAG="-no-site-file"
+
FLAGS="${SITEFLAG} -q -batch -l path.el -f batch-byte-compile"
ELDIR=/usr/share/emacs/site-lisp/${PACKAGE}
