Package: zfs-fuse
Version: 0.6.9-1
Severity: wishlist
Tags: patch

Hi.

I've attached a patch for the init-script, apply what you find reasonable.

- some cosmetic issues (indenting, messages), although there could be still
  done more
- removed "documentating" stuff (reference to the defaults-file) when zfs-fuse
  has been disabled
- changed two exit 1 to exit 0, which IMHO do not justify a failed status
  (which is then also used e.g. by sysvinit)


Cheers,
Chris.

btw: why does the script depend on $remote_fs and why that LANG= setting?
--- zfs-fuse    2010-07-02 20:48:04.519784647 +0200
+++ zfs-fuse    2010-07-02 20:54:18.150784900 +0200
@@ -119,14 +119,14 @@
 
 do_start() {
     if is_running; then
-        log_action_msg "zfs-fuse is already running"
-        return 1
+        log_action_msg "zfs-fuse is already running."
+        return 0
     fi
     if [ "x$ENABLE_ZFS" != "xyes" ]; then
-        log_action_msg "Disabled by /etc/default/$NAME" >&2
-        return 1
+        log_action_msg "zfs-fuse is disabled." >&2
+        return 0
     fi
-       upgrade_zpool_cache_location
+    upgrade_zpool_cache_location
     log_daemon_msg "Starting $NAME" "zfs-fuse"
     ulimit -v unlimited
     ulimit -c 512000

Reply via email to