Package: syslinux
Version: 2:4.01+dfsg-3
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch maverick

dpkg-buildflags(1) allows setting compilation flags for use while
building Debian packages.  It documents LDFLAGS as follows:

       LDFLAGS
              Options passed to the compiler when linking executables or
              shared objects (if the linker is called directly, then -Wl
              and , have to be stripped from these options). Default
              value: empty.

However, syslinux passes LDFLAGS directly to the linker without
stripping "-Wl,", so if you set LDFLAGS in the documented way here then
it breaks.  It seems simplest to just unexport it for the moment;
default LDFLAGS like this are usually performance tweaks like
-Wl,-Bsymbolic-functions, so ignoring them is probably no big deal.

--- syslinux-4.01+dfsg/debian/rules
+++ syslinux-4.01+dfsg/debian/rules
@@ -5,6 +5,12 @@
 DATE=$(shell date +%Y%m%d)
 VERSION=$(word 1,$(shell cat version))
 
+# If a default LDFLAGS is set using dpkg-buildflags, then it is supposed to
+# be in the format expected by the compiler, i.e. with leading "-Wl,".
+# Syslinux often passes LDFLAGS directly to the linker, so this breaks.  For
+# now, it's simplest just not to honour it at all.
+unexport LDFLAGS
+
 %:
        dh --with quilt $...@}
 

(With this and the three patches I just sent upstream, Ubuntu can at
long last just use Debian's syslinux and gfxboot packages without
modifications.  Thanks!)

-- 
Colin Watson                                       [[email protected]]



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to