Thanks for the patch. Will (probably) be applied later today.
Regards,
// Ola
On Mon, Aug 15, 2005 at 01:59:26PM +0200, Lionel Elie Mamane wrote:
> On Sun, Aug 14, 2005 at 08:31:49PM +0200, Ola Lundqvist wrote:
> > On Sun, Aug 14, 2005 at 05:55:24PM +0200, Laurent Fousse wrote:
>
> >> There are some more occurrences of the problem in the source code. On
> >> our system one user reported seeing the warning for
> >> lib/MIME/Viewer.php, line 64. Adjusting priority as this no longer
> >> prevents a successful login.
>
> > Ok. I'll see what I can do. Patch for this is of course welcome.
>
> Here is a patch, applying the same fix as for the other
> occurrences. As I don't know in what situation the user saw that
> warning, I cannot formally test it.
>
> --
> Lionel
> --- Viewer.php.deb 2005-08-15 13:49:32.987860274 +0200
> +++ Viewer.php 2005-08-15 13:51:23.370048759 +0200
> @@ -61,7 +61,8 @@
> @include_once MIME_Viewer::resolveDriver($driver, $app);
> $class = (($app == 'horde') ? '' : $app . '_') . 'MIME_Viewer_' .
> $driver;
> if (class_exists($class)) {
> - return new $class($mime_part, $mime_drivers[$app][$driver]);
> + $result = new $class($mime_part, $mime_drivers[$app][$driver]);
> + return $result;
> } else {
> return false;
> }
--
--------------------- Ola Lundqvist ---------------------------
/ [EMAIL PROTECTED] Annebergsslingan 37 \
| [EMAIL PROTECTED] 654 65 KARLSTAD |
| +46 (0)54-10 14 30 +46 (0)70-332 1551 |
| http://www.opal.dhs.org UIN/icq: 4912500 |
\ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
---------------------------------------------------------------
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
