Hi Guido, thanks for working on this.
On 28.07.2010 12:32, Guido Günther wrote: > Hi Joss, > On Fri, Jul 23, 2010 at 03:19:08PM +0200, Josselin Mouette wrote: >> Le vendredi 23 juillet 2010 à 14:57 +0200, Guido Günther a écrit : >>> A new upstream version is also needed to support cups-pk-helper. This >>> makes is possible to have finer grained actions using policy kit. >> >> I don’t have a printer anymore so I will probably not work on >> system-config-printer before the squeeze release. >> >> Help is welcome. > > I've updated the package at: > > http://git.debian.org/?p=users/agx/system-config-printer.git;a=summary > > and it works here. A few comments/suggestions: - Build-Depends on quilt can/should be dropped. - libudev-dev Build-Depends is linux only [linux-any]. - system-config-printer-udev should be Architecture: linux-any - hal-cups-utils should probably depend on system-config-printer-udev [linux-any]. Does system-config-printer have a fallback for non-udev systems? What happens to the original hal-cups-utils source package? Does it make sense to keep it around for non-linux systems? The general question here is, how to handle kbsd/hurd - seems debian/control and debian/control.in are out-of-sync - long package description of hal-cups-utils: the "." should be indented with one white space, not two. - changelog: "Conflict on hal-cups-utils since system-config-printer- udev provides" should probably be "Conflict with hal-cups-utils since system-config-printer-udev provides" - Should the package be split in GUI + core, i.e. move the GNOME bits in a system-config-printer-gnome package? Is system-config-printer-kde actually usable without system-config-printer installed? If not, it would need a dependency on GNOME bits. - I'm not a python packager, but the python bits are installed as /usr/lib/python2.6/site-packages/cupshelpers/*. Shouldn't the python-cupsutils package be renamed to python-cupshelpers? Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature