forwarded 592201 https://bugs.freedesktop.org/show_bug.cgi?id=29447 thanks
On Sun, 2010-08-08 at 08:06 +0200, Petter Reinholdtsen wrote:
> Package: shared-mime-info
> Version: 0.71-3
> Severity: minor
> Tags: patch
>
> When installing packages in Squeeze, messages like this show up in the
> installation log. Notice the blank line between the warnings:
>
> Aug 7 10:40:31 in-target: Behandler utløsere for shared-mime-info ...
> Aug 7 10:40:32 in-target: Unknown media type in type 'all/all'
> Aug 7 10:40:32 in-target:
> Aug 7 10:40:32 in-target: Unknown media type in type 'all/allfiles'
> Aug 7 10:40:32 in-target:
> Aug 7 10:40:32 in-target: Unknown media type in type 'uri/mms'
> Aug 7 10:40:32 in-target:
> Aug 7 10:40:32 in-target: Unknown media type in type 'uri/mmst'
> Aug 7 10:40:32 in-target:
> Aug 7 10:40:32 in-target: Unknown media type in type 'uri/mmsu'
>
> Can the output be changed to not have a blank line between these
> warnings? After installing a few packages, quite a lot of these
> messages start to show up, and this make the log a bit harder to
> follow when tracing the installation.
>
> I checked the source, and the code in question use g_warning to print
> these messages. The g_warning() call seem to insert its own newline
> in addition to the one already in the message, causing the double
> newlines.
>
> I tested this theory using this small C code:
>
> #include <glib.h>
> int main(int argc, char *argv[]) {
> g_warning("test1");
> g_warning("test2\n");
> g_warning("test3");
> }
>
> Its output when compiled with glib 2.1 is:
>
>
> ** WARNING **: test1
>
> ** WARNING **: test2
>
>
> ** WARNING **: test3
>
> Based on this, I believe it should be safe to drop the newline from
> the calls to g_warning(), and propose this patch:
Thanks, I've forwarded this upstream:
https://bugs.freedesktop.org/show_bug.cgi?id=29447
Your analysis is of course correct :)
signature.asc
Description: This is a digitally signed message part
