On Aug 16, 2010, at 9:41 PM, Thomas Goirand wrote: > Clint Byrum wrote: >> Attached script does just that (tho still depends on my run_test_driver.sh) > > Hi Clint, > > Thanks to your help, I managed to have the package in good shape, > including the PGSQL tests. I believe that the package is now in order, > and that I could upload it to SID (or experimental). Please check for it > for a last time: >
Excellent! > http://ftparchive.gplhost.com/pub/libdbi/sid/ > It works great. I installed from those binaries, tested it with rrdtool, libdbi 0.8.2 and 0.8.3, and all is well. I did get a failure on rebuilding on a (mostly updated) debian squeeze box: SUCCESS! All done, disconnecting and shutting down libdbi. Have a nice day. kill: 74: Illegal number: /tmp/tmp.W6j2ka26px LOG: received smart shutdown request make: *** [test-stamp] Error 2 LOG: autovacuum launcher shutting down dpkg-buildpackage: error: debian/rules build gave error exit status 2 Because of the set -e, that kill snafu prematurely ended test_pgsql.sh. That kill is unnecessary, and can be replaced with $BINDIR/pg_ctl stop -D ${MYTMPDIR} Which more or less does the same thing. > As it includes the test suite, I am confident that it must be working > quite well. However, you are welcome to test it under your environment > and report here. As soon as I have your reply, I'll upload to SID, I > think, and maybe ask for a freeze exception. > Agreed, the effort should pay off in the long run, even if libdbi-drivers totally revamps their testing suite. :) I was thinking actually that we should submit the test_mysql and test_postgres scripts upstream, as in the form they're in now, they're very safe and quite complete. > Thanks again for your precious contribution here, > let me know what you think of the package, > Its been my pleasure. I am excited to see the work uploaded. One final issue, I think the two test_XXX scripts should be tagged with a license and copyright notices, to remove any ambiguity. Generally shell scripts are pretty trivial and I wouldn't care, but these really are not trivial at all. I'd expect you'd also want your copyright to be added there as well, as this was really done collaboratively. Of course, that is entirely up to you. I'm more concerned about making sure the file is clearly licensed than who is attributed as copyright holder(s). Its not a huge deal, but I think it ensures nobody will have to wonder about the licensing status of the files, which is especially helpful if upstream wants to incorporate them for their releases. patch attached...
libdbi-drivers-add-license.diff
Description: Binary data
