Modified: trunk/share/arno-iptables-firewall/environment
===================================================================
--- trunk/share/arno-iptables-firewall/environment 2010-08-25 07:50:13 UTC (rev 274) +++ trunk/share/arno-iptables-firewall/environment 2010-08-25 12:01:51 UTC (rev 275)
@@ -391,7 +391,11 @@
     printf "\033[40m\033[1;31msysctl $@: ($retval) $result\033[0m\n" >&2
     return $retval
   fi
-  echo "${INDENT}sysctl $@"
+
+  if [ -n "$result" ]; then
+    echo "${INDENT}$result"
+  fi
+
   return 0
 }

@@ -424,7 +428,9 @@
       retval=$?

       if [ "$retval" = "0" ]; then
-        echo "${INDENT}${sysctl_commandline}"
+        if [ -n "$result" ]; then
+          echo "${INDENT}$result"
+        fi
         return 0
       else
printf "\033[40m\033[1;31m${sysctl_commandline}: ($retval) $result\033[0m\n" >&2


This is the patch for 1.9.2l-DEVEL. Maybe it doesn't work on 1.9.2k properly, but the bottomline line is that sysctl() should only output its result when it's non-empty, and only that, not it's full commandline as it breaks grep's using the result.


cheers,

Arno

On 8/25/2010 14:15, Michael Hanke wrote:
Hi Arno,

On Wed, Aug 25, 2010 at 01:33:08PM +0200, Arno van Amersfoort wrote:
This was the intended behaviour, but due to a bug it doesn't work.
I'll fix it today, hopefully Debian will backport the fix or allow
upcoming 1.9.2k to enter Sqeeuze.

Could you please provide me with a bugfix patch for the current -k
release that fixes this. I'm not sure that a complete new upstream
release will make it into squeeze (unless it doesn't have anything but
bugfixes).

Thanks,

Arno


--
Arno van Amersfoort
E-mail    : arn...@rocky.eld.leidenuniv.nl
Donations are welcome through Paypal!
---------------------------------------------------------------------------
Arno's (Linux IPTABLES Firewall) Homepage:
http://rocky.eld.leidenuniv.nl



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to