On Tue, August 31, 2010 20:16, Thomas Goirand wrote: > Thijs Kinkhorst wrote: >> Two questions: >> >> 1) Why is it needed to pass the object by reference? It looks like it >> could >> just as well be passed by value. >> >> 2) Why is this bug of grave severity? As I understand it, using this >> only >> generates notices of level E_DEPRECATED. The code functions just as it >> did >> before. >> >> >> Cheers, >> Thijs > > Hi Thijs, > > I have made the necessary corrections to the package. Attached is an > interdiff between the 2 versions. Please have a quick look/review, and > let me know if you think it's ok that I upload the amended version.
You're using "prereg_match" which I think is a misspelling of the "preg_match" function. Did you test it? I was wondering apart from this why you keep the ereg(i) calls. All versions of PHP also support preg_match, so you can just replace them with preg_match calls unconditionally. Cheers, Thijs -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
