Hi Russ, On Wed, Sep 01, 2010 at 03:54:52PM -0700, Russ Allbery wrote: > Guido Günther <[email protected]> writes: > > On Tue, Aug 31, 2010 at 11:33:56AM -0700, Svend Sorensen wrote: > > [..snip..] > > >> There is no way to specify the architecture when running "git-pbuilder > >> create". If additional arguments were passed to cowbuilder, one could > >> run "git-pbuilder create --architecture i386" to create an i386 image > >> on an amd64 system. The attached patch allows this. > > I included the patch to support extra arguments, since I think that's a > good idea regardless. > > > While I do think this make sense I do wonder if we wouldn't have to > > encode the architecture in the name of the basepath in your example. > > Otherwise it wouldn't be possible to have a sid baseimage for amd64 and > > i386 on the same machine. > > > I see two solutions here: making it possible to override $BASE too or to > > add a --arch option to git-pbuilder that adds the architecture to $BASE. > > --arch as an option will have trouble for the same reason that --dist as > an option doesn't always work: you may not easily be able to get options > passed down to the builder script. I've therefore instead added another > environment variable, ARCH, which works the same way as DIST. If ARCH is > set, it passes the --architecture flag along to cowbuilder, and it also > changes the base path to be base-<dist>-<arch>.cow. This looks great. I've resynced it git-buildpackage's git with it. -- Guido
-- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
