Bug#597504: Remote TimedLogin disabled in gdm3

[mariodebian]

> 
> Remote autologin looks like a very bad idea to me.
> 
> There’s no way I’m adding this without the AllowRemoteAutoLogin key
> being back too. And really, it sounds like a ShootMyselfInTheFoot key.
> 
> Cheers,


We use GDM in thin client environments and most of them are in kiosk
mode (libraries, telecenters, council public access, etc...).

In older versions, when GDM call autologin script, we clean the $HOME
dir, and do autologin.

KDM have autologin based on $DISPLAY name/hostname


I attach a better patch, that reads AllowRemoteAutoLogin.

With this patch user must explicit enable it, and TimedLogin must end on
a pipe "|" to be evaluated as script.


Please, reconsider it.


Greetings
--
http://mariodebian.com

Index: gdm3-2.30.5/daemon/gdm-xdmcp-display.c
===================================================================
--- gdm3-2.30.5.orig/daemon/gdm-xdmcp-display.c	2010-09-20 12:17:39.000000000 +0200
+++ gdm3-2.30.5/daemon/gdm-xdmcp-display.c	2010-09-20 12:28:30.000000000 +0200
@@ -41,6 +41,10 @@
 #include "gdm-common.h"
 #include "gdm-address.h"
 
+#include "gdm-settings.h"
+#include "gdm-settings-direct.h"
+#include "gdm-settings-keys.h"
+
 #define GDM_XDMCP_DISPLAY_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE ((o), GDM_TYPE_XDMCP_DISPLAY, GdmXdmcpDisplayPrivate))
 
 struct GdmXdmcpDisplayPrivate
@@ -190,6 +194,14 @@
         *enabledp = FALSE;
         *usernamep = g_strdup ("");
         *delayp = 0;
+        gboolean allow_remote_autologin;
+
+        allow_remote_autologin = FALSE;
+        gdm_settings_direct_get_boolean (GDM_KEY_ALLOW_REMOTE_AUTOLOGIN, &allow_remote_autologin);
+
+        if ( allow_remote_autologin ) {
+                GDM_DISPLAY_CLASS (gdm_xdmcp_display_parent_class)->get_timed_login_details (display, enabledp, usernamep, delayp);
+        }
 }
 
 static void
Index: gdm3-2.30.5/data/gdm.schemas.in.in
===================================================================
--- gdm3-2.30.5.orig/data/gdm.schemas.in.in	2010-09-20 12:18:09.000000000 +0200
+++ gdm3-2.30.5/data/gdm.schemas.in.in	2010-09-20 12:18:09.000000000 +0200
@@ -79,6 +79,11 @@
       <signature>b</signature>
       <default>true</default>
     </schema>
+    <schema>
+      <key>security/AllowRemoteAutoLogin</key>
+      <signature>b</signature>
+      <default>false</default>
+    </schema>
 
     <schema>
       <key>greeter/Include</key>
Index: gdm3-2.30.5/common/gdm-settings-keys.h
===================================================================
--- gdm3-2.30.5.orig/common/gdm-settings-keys.h	2010-09-20 12:18:09.000000000 +0200
+++ gdm3-2.30.5/common/gdm-settings-keys.h	2010-09-20 12:18:09.000000000 +0200
@@ -44,6 +44,7 @@
 #define GDM_KEY_INCLUDE_ALL "greeter/IncludeAll"
 
 #define GDM_KEY_DISALLOW_TCP "security/DisallowTCP"
+#define GDM_KEY_ALLOW_REMOTE_AUTOLOGIN "security/AllowRemoteAutoLogin"
 
 #define GDM_KEY_XDMCP_ENABLE "xdmcp/Enable"
 #define GDM_KEY_MAX_PENDING "xdmcp/MaxPending"

signature.asc
Description: This is a digitally signed message part