On Sat, Oct 30, 2010 at 03:35:47PM -0500, Zach Davis wrote: >I am writing to let you know that the gtkterm upstream package has a >new maintainer. Julien no longer has the time to maintain it, and has >passed it on to me. > >The new site is at: https://fedorahosted.org/gtkterm/ > >There has been a new release (0.99.6) and I recommend you consider >moving to it. This release has no big changes, only existing patches >have been applied, and a few bugfixes. > >I am happy to hear any concerns or requests.
This is my request. :)
Sorry if the following changes are already in the new release 0.99.6.
Please consider the patch in the attachment of this message.
Also, in debian/changelog we have:
* 03_ubuntu_configure.in.patch:
adjusted to provide diffs against new automake/autotools versions
* 03_ubuntu_configure.in.patch:
Add $TERMINAL_WIDGET_CFLAGS to the standard CFLAGS,
to find the VTE include files
So, please consider changing configure.in to add
$TERMINAL_WIDGET_CFLAGS to the standard CFLAGS.
gtkterm-0.99.5.new/src/widgets.c | 8 ++++++++
src/serie.c | 4 +++-
src/widgets.c | 2 +-
3 files changed, 12 insertions(+), 2 deletions(-)
--- gtkterm-0.99.5.orig/src/serie.c
+++ gtkterm-0.99.5/src/serie.c
@@ -389,7 +389,9 @@
{
if(ioctl(serial_port_fd, TIOCMGET, &stat_read) == -1)
{
- i18n_perror(_("Control signals read"));
+ /* Ignore EINVAL, as some serial ports genuinely lack these lines */
+ if (errno != EINVAL)
+ i18n_perror(_("Control signals read"));
return -2;
}
https://bugs.launchpad.net/ubuntu/+source/gtkterm/+bug/60400
Added 01_ubuntu_segfault.patch for fixing segfault when sending
empty hexadecimal data.
Fix was created by Elie De Brauwer
diff -Nur gtkterm-0.99.5/src/widgets.c gtkterm-0.99.5.new/src/widgets.c
--- gtkterm-0.99.5/src/widgets.c 2005-09-22 23:13:00.000000000 +0300
+++ gtkterm-0.99.5.new/src/widgets.c 2007-01-19 19:09:44.000000000 +0200
@@ -609,6 +609,14 @@
text = (gchar *)gtk_entry_get_text(GTK_ENTRY(widget));
+ if(strlen(text) ==0){
+ message = g_strdup_printf(_("0 byte(s) sent !"));
+ Put_temp_message(message, 1500);
+ gtk_entry_set_text(GTK_ENTRY(widget), "");
+ g_free(message);
+ return FALSE;
+ }
+
all_written = g_malloc(strlen(text) * 2);
all_written[0] = 0;
https://bugs.launchpad.net/ubuntu/+source/gtkterm/+bug/60400
Fix the length of the written buffer in src/widget.c to include the
null termination of the string iand fix a segfault (LP: #60400).
Thanks to sdaau (https://launchpad.net/~sd-imi) for the patch.
diff -Nur -x '*.orig' -x '*~' gtkterm-0.99.5/src/widgets.c
gtkterm-0.99.5.new/src/widgets.c
--- gtkterm-0.99.5/src/widgets.c 2009-12-12 05:30:15.450895958 +0000
+++ gtkterm-0.99.5.new/src/widgets.c 2009-12-12 05:31:03.410879690 +0000
@@ -604,7 +604,7 @@
guchar val;
guint val_read;
guint sent = 0;
- gchar written[3];
+ gchar written[4];
gchar *all_written;
text = (gchar *)gtk_entry_get_text(GTK_ENTRY(widget));
signature.asc
Description: Digital signature
