On Mon, Nov 08, 2010, Jérémy Lal wrote: > i'm removing the march=armv4t flag from SContruct (it was a patch anyway), > since it's up to the debian gcc armel default target to decide which arch > it should compile for. > I'm also checking if the other flag no-thumb-interwork is still needed, > since there has been some upstream work on it recently. > I don't think other changes are needed. Do you ? > To be uploaded with libv8 2.4.9.12.
I would be careful when removing the march=armv4t and other flags; I think it's the right thing to do, but other places might have to be patched; for instance, I see ANDROID_FLAGS for instance has it hardcoded, while it doesn't apply to linux/kfreebsd builds, there might be some hidden nasty flags somewhere which motivated the addition of this patch. I would grep the build log on armel for suspicious flags like -march/-mcpu/-mtune and probably -marm/-mthumb*. -mno-thumb-interwork is a bit suspicious; I'm not entirely comfortable on the architecture revisions and cases where these flags are explicitly needed, but in any case the toolchain defaults should be fine. -fno-tree-sink seems to be a workaround for a compiler bug (disabling an optimization). -Wno-psabi is undocumented in my version of gcc. The "nop" seems a bit weird; I can see how it fixes the compilation, but it probably doesn't fulfill the expected purpose. Seems to only be used for debug, so not a big deal I guess. -- Loïc Minier -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
