On Di, 2010-11-23 at 15:51 +0100, Josselin Mouette wrote:
> Package: update-notifier
> Version: 0.99.3debian7
>
> Hi,
>
> the last version of update-notifier is a huge improvement for displaying
> relevant information even to non-admins, but a small yet annoying glitch
> remains.
>
> Here are the steps to reproduce.
> * One user (guru) is in the sudo group, one user (n00b) is not.
> * Log-in as n00b, while some updates are available. No icon is
> displayed, as expected.
> * As guru (or root), install one of the updates (with apt-get
> install foo, not apt-get upgrade). During the installation, n00b
> gets a gray icon warning that an upgrade is in progress. This is
> expected.
> * After the update is complete, there are still other updates
> available. Then, the icon on n00b’s session becomes yellow and
> it proposes to install them with gksu when clicking on it.
> I think in this case, the icon should disappear, to come back to the
> status it was in before the upgrade was in progress.
I guess the following patch should work.
=== modified file 'src/update.c'
--- src/update.c 2010-11-22 18:52:24 +0000
+++ src/update.c 2010-11-23 18:35:40 +0000
@@ -639,8 +639,12 @@ update_check (TrayApplet *ta)
// only admins are interested in available updates, for others we just
// display when an update is in progress to inform them about it.
- if (!in_admin_group())
+ if (!in_admin_group()) {
+ // we really do not want to show them available updates (Debian #604694)
+ if(gtk_status_icon_get_visible (ta->tray_icon))
+ gtk_status_icon_set_visible (ta->tray_icon, FALSE)
return TRUE;
+ }
// check if the user wants to see the icon or launch
// the default action
>
> On a side note: when a reboot is needed, n00b doesn’t get the reboot
> proposal. I don’t know whether it is intentional. I think it should see
> that icon, since if he’s the one using the machine at that moment, he
> should be the one rebooting it too.
I don't know why this happens (it's a separate icon from the update
icon, so not related to it).
--
Julian Andres Klode - Debian Developer, Ubuntu Member
See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
