On Sun, 28 Nov 2010 14:15:19 +0100, Giuseppe Sacco wrote:

> I reviewed your patch and I think it does not solve completely the
> problem.

That's possible :)
 
> When you are in a chroot environment, /proc/mounts show all mounts on
> all chroot, so you cannot know for sure if the one you found (and you
> may found more than one) is yours.

True.

> /etc/mtab only contains mounted volumes in current system (or chroot),
> so using it does solve the problem.

Except that there are situations where it doesn't exist, and IIRC
there's no guarantee it's up2date and matching reality.
 
> Back to fixing this bug. Probably, I would suggest, when /etc/mtab is
> missing, to assume that $SPOOL/etc is not mounted with bind option.
> 
> What is your opinion about this?

I agree that checking for the existence of /etc/mtab before using it
is a good idea and would solve _this_ bug.

Honestly I don't know if it's correct to base assumptions on it but I
leave this to people actually knowing the software :)


Thanks for your quick reply!

Cheers,
gregor

-- 
 .''`.   http://info.comodo.priv.at/ -- GPG key IDs: 0x8649AA06, 0x00F3CFE4
 : :' :  Debian GNU/Linux user, admin, & developer - http://www.debian.org/
 `. `'   Member of VIBE!AT & SPI, fellow of Free Software Foundation Europe
   `-    BOFH excuse #378:  Operators killed by year 2000 bug bite. 

Attachment: signature.asc
Description: Digital signature

Reply via email to